search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

feat: add OER support for ILQP packets #52

Closed andrew-g-za closed 7 years ago

andrew-g-za commented 7 years ago

@sappenin - please take a look at OerIA5StringCodec and OerLengthPrefixCodec, i made a few changes to ensure that length indicators are checked more carefully, and (i think) improved performance for the string codec (encode to byte[] once instead of twice).

I have an issue open for the GeneralizedTime format referenced in the LiquidityResponse, i figure lets get the rest in so long while that gets resolved.

codecov-io commented 7 years ago

Codecov Report

Merging #52 into development will increase coverage by 6.47%. The diff coverage is 65.73%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development      #52      +/-   ##
=================================================
+ Coverage           52.4%   58.88%   +6.47%     
- Complexity           160      190      +30     
=================================================
  Files                 61       67       +6     
  Lines               1124     1340     +216     
  Branches             115      137      +22     
=================================================
+ Hits                 589      789     +200     
+ Misses               483      469      -14     
- Partials              52       82      +30
Impacted Files Coverage Δ Complexity Δ
...es/QuoteByDestinationAmountResponsePacketType.java 100% <ø> (ø) 1 <0> (?)
...rg/interledger/codecs/oer/OerOctetStringCodec.java 63.33% <ø> (ø) 4 <0> (ø) :arrow_down:
...pes/QuoteByDestinationAmountRequestPacketType.java 100% <ø> (ø) 1 <0> (?)
...interledger/codecs/QuoteLiquidityRequestCodec.java 100% <ø> (+100%) 2 <0> (+2) :arrow_up:
...kettypes/QuoteBySourceAmountRequestPacketType.java 100% <ø> (ø) 1 <0> (?)
...ettypes/QuoteBySourceAmountResponsePacketType.java 100% <ø> (ø) 1 <0> (?)
...codecs/oer/ilqp/QuoteLiquidityRequestOerCodec.java 100% <100%> (ø) 3 <3> (?)
...g/interledger/codecs/oer/OerLengthPrefixCodec.java 66.15% <100%> (+1.07%) 13 <0> (+1) :arrow_up:
.../ilqp/QuoteByDestinationAmountRequestOerCodec.java 100% <100%> (ø) 3 <3> (?)
...ger/codecs/oer/ilp/InterledgerPaymentOerCodec.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a694011...c60b8eb. Read the comment docs.