search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

Feature/prepare maven central #55

Closed sappenin closed 7 years ago

sappenin commented 7 years ago

This PR updates the gradle build file to allow for code signing and artifact deploy to Sonatype, which mirrors out to Maven Central.

Additionally, there are minor formatting and Javadoc changes.

codecov[bot] commented 7 years ago

Codecov Report

Merging #55 into development will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development      #55   +/-   ##
==============================================
  Coverage          55.48%   55.48%           
  Complexity           193      193           
==============================================
  Files                 72       72           
  Lines               1449     1449           
  Branches             154      154           
==============================================
  Hits                 804      804           
  Misses               561      561           
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...ilqp/QuoteByDestinationAmountResponseOerCodec.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
.../oer/ilqp/QuoteBySourceAmountResponseOerCodec.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
...s/oer/ilqp/QuoteBySourceAmountRequestOerCodec.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
...ava/org/interledger/codecs/oer/OerUint32Codec.java 58.82% <ø> (ø) 5 <0> (ø) :arrow_down:
.../ilqp/QuoteByDestinationAmountRequestOerCodec.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
...codecs/oer/ilqp/QuoteLiquidityRequestOerCodec.java 100% <ø> (ø) 3 <0> (ø) :arrow_down:
...rledger/ilqp/QuoteByDestinationAmountResponse.java 44.44% <ø> (ø) 0 <0> (ø) :arrow_down:
...ain/java/org/interledger/ilp/InterledgerError.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c27c3be...ed8e8eb. Read the comment docs.

sappenin commented 7 years ago

This PR is a good first step - it allows me to manually publish SNAPSHOTS and releases, but I'd like to get CircleCI at least publishing SNAPSHOTS when the development branch is built. Unfortunately, I am unable to get gradle to read the environment variables from CircleCI, so that's not yet working -- I plan to spend some more time on that this weekend.

sappenin commented 7 years ago

Just pushed one more change for the naming - let me know what you think @adrianhopebailie