search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

Switch to BigInteger from long #57

Closed adrianhopebailie closed 7 years ago

adrianhopebailie commented 7 years ago

We are still using a long in many places for amounts. These are encoded as UInt64 which is too big for a long so there is a risk that we'll break things.

Need to switch to BigInteger and stop using deprecated functions on the UInt64 codecs.

NOTE: Need to ensure that we encode and decode accurately as the default byte encoding of BigInteger includes a sign bit. We only want unsigned 64 bit integers.

andrew-g-za commented 7 years ago

+1

The OerUint64 codec already has this, so its just a matter of updating all the models to use BigInteger instead of long.