Closed andrew-g-za closed 7 years ago
Merging #68 into development will increase coverage by
1.44%
. The diff coverage is70.94%
.
@@ Coverage Diff @@
## development #68 +/- ##
=================================================
+ Coverage 64.35% 65.79% +1.44%
- Complexity 182 193 +11
=================================================
Files 64 69 +5
Lines 1554 1713 +159
Branches 177 191 +14
=================================================
+ Hits 1000 1127 +127
- Misses 462 485 +23
- Partials 92 101 +9
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...g/interledger/codecs/oer/OerLengthPrefixCodec.java | 74.13% <ø> (ø) |
13 <0> (ø) |
:arrow_down: |
.../ilqp/QuoteByDestinationAmountRequestOerCodec.java | 100% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
...ava/org/interledger/codecs/oer/OerUint64Codec.java | 71.42% <ø> (ø) |
5 <0> (ø) |
:arrow_down: |
...s/oer/ilqp/QuoteBySourceAmountRequestOerCodec.java | 100% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
...codecs/oer/ilqp/QuoteLiquidityRequestOerCodec.java | 100% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
.../org/interledger/codecs/oer/OerIA5StringCodec.java | 77.14% <ø> (ø) |
6 <0> (ø) |
:arrow_down: |
...ava/org/interledger/codecs/oer/OerUint32Codec.java | 64.51% <ø> (ø) |
5 <0> (ø) |
:arrow_down: |
.../interledger/ilqp/QuoteBySourceAmountResponse.java | 53.57% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...g/interledger/ilqp/QuoteBySourceAmountRequest.java | 55.88% <0%> (ø) |
0 <0> (ø) |
:arrow_down: |
...va/org/interledger/ilqp/QuoteLiquidityRequest.java | 65.21% <0%> (+5.21%) |
0 <0> (ø) |
:arrow_down: |
... and 25 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f4dd27d...ac3cef0. Read the comment docs.
Merging #68 into development will increase coverage by
1.17%
. The diff coverage is72.98%
.
@@ Coverage Diff @@
## development #68 +/- ##
=================================================
+ Coverage 64.35% 65.52% +1.17%
- Complexity 182 193 +11
=================================================
Files 64 69 +5
Lines 1554 1720 +166
Branches 177 194 +17
=================================================
+ Hits 1000 1127 +127
- Misses 462 492 +30
- Partials 92 101 +9
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...ava/org/interledger/codecs/oer/OerUint32Codec.java | 64.51% <ø> (ø) |
5 <0> (ø) |
:arrow_down: |
.../org/interledger/codecs/oer/OerIA5StringCodec.java | 77.14% <ø> (ø) |
6 <0> (ø) |
:arrow_down: |
.../ilqp/QuoteByDestinationAmountRequestOerCodec.java | 100% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
...rledger/ilqp/QuoteByDestinationAmountResponse.java | 53.57% <ø> (ø) |
0 <0> (ø) |
:arrow_down: |
.../interledger/ilqp/QuoteBySourceAmountResponse.java | 53.57% <ø> (ø) |
0 <0> (ø) |
:arrow_down: |
...erledger/ilqp/QuoteByDestinationAmountRequest.java | 55.88% <ø> (ø) |
0 <0> (ø) |
:arrow_down: |
...codecs/oer/ilqp/QuoteLiquidityRequestOerCodec.java | 100% <ø> (ø) |
3 <0> (ø) |
:arrow_down: |
...ava/org/interledger/codecs/oer/OerUint64Codec.java | 71.42% <ø> (ø) |
5 <0> (ø) |
:arrow_down: |
...g/interledger/ilqp/QuoteBySourceAmountRequest.java | 55.88% <ø> (ø) |
0 <0> (ø) |
:arrow_down: |
...g/interledger/codecs/oer/OerLengthPrefixCodec.java | 74.13% <ø> (ø) |
13 <0> (ø) |
:arrow_down: |
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f4dd27d...e8fe4df. Read the comment docs.
@andrew-g-za please squash and merge after fixing those two comments
Hey chaps,
At last, the liquidity quote codec. I've also fixed a few things here and there, particularly our .toString convention of starting with 'Impl{..}' - which Impl?
p.s. I had some weird merging issues, hopefully it doesnt get too confusing. If it does, i'll just check out the dev branch and drop my changes on top (since we squash + merge, it should be the same i think)