search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

Fixes #57 (Transition Amount to BigDecimal) #73

Closed sappenin closed 7 years ago

sappenin commented 7 years ago
adrianhopebailie commented 7 years ago

Transitions all java-ilp-core “amount” fields to be BigDecimal

I think you mean BigInteger?

LGTM

codecov[bot] commented 7 years ago

Codecov Report

Merging #73 into development will increase coverage by 2.14%. The diff coverage is 96.61%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development     #73      +/-   ##
================================================
+ Coverage          70.46%   72.6%   +2.14%     
- Complexity           207     212       +5     
================================================
  Files                 73      73              
  Lines               1862    1869       +7     
  Branches             203     199       -4     
================================================
+ Hits                1312    1357      +45     
+ Misses               441     414      -27     
+ Partials             109      98      -11
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/interledger/psk/PskMessage.java 86.81% <ø> (ø) 1 <0> (ø) :arrow_down:
src/main/java/org/interledger/Condition.java 56% <ø> (ø) 2 <0> (ø) :arrow_down:
...ava/org/interledger/codecs/oer/OerUint64Codec.java 68.75% <ø> (-2.68%) 5 <0> (ø)
...n/java/org/interledger/ilp/InterledgerPayment.java 75% <ø> (ø) 1 <0> (ø) :arrow_down:
...va/org/interledger/codecs/oer/OerUint256Codec.java 46.87% <ø> (ø) 3 <0> (ø) :arrow_down:
.../oer/ilqp/QuoteBySourceAmountResponseOerCodec.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
...g/interledger/ilqp/QuoteBySourceAmountRequest.java 86.48% <100%> (+30.6%) 1 <1> (+1) :arrow_up:
...ger/codecs/oer/ilp/InterledgerPaymentOerCodec.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
...s/oer/ilqp/QuoteBySourceAmountRequestOerCodec.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
...ilqp/QuoteByDestinationAmountResponseOerCodec.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5c6bb1...6896ceb. Read the comment docs.