interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

Cleanup non-core sub-packages #74

Closed adrianhopebailie closed 7 years ago

adrianhopebailie commented 7 years ago

Remove ledger and setup sub-packages Rename module to ilp-core (drop "java" prefix) Drop Java Money dependency

adrianhopebailie commented 7 years ago

@sappenin let me know when you have merged #73 and #72 and I'll rebase

codecov[bot] commented 7 years ago

Codecov Report

Merging #74 into development will increase coverage by 1.28%. The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             development      #74      +/-   ##
=================================================
+ Coverage          72.63%   73.91%   +1.28%     
+ Complexity           216      207       -9     
=================================================
  Files                 73       68       -5     
  Lines               1871     1775      -96     
  Branches             199      197       -2     
=================================================
- Hits                1359     1312      -47     
+ Misses               414      354      -60     
- Partials              98      109      +11
Impacted Files Coverage Δ Complexity Δ
...erledger/ilqp/QuoteByDestinationAmountRequest.java 55.88% <0%> (-30.96%) 0% <0%> (-1%)
...g/interledger/ilqp/QuoteBySourceAmountRequest.java 55.88% <0%> (-30.61%) 0% <0%> (-1%)
...rledger/ilqp/QuoteByDestinationAmountResponse.java 53.57% <0%> (-29.77%) 0% <0%> (-1%)
.../interledger/ilqp/QuoteBySourceAmountResponse.java 53.57% <0%> (-29.77%) 0% <0%> (-1%)
...main/java/org/interledger/ilqp/LiquidityPoint.java 69.23% <0%> (-8.55%) 0% <0%> (-1%)
.../main/java/org/interledger/InterledgerAddress.java 95.45% <0%> (-0.2%) 5% <0%> (-4%)
src/main/java/org/interledger/psk/PskMessage.java 86.81% <0%> (ø) 1% <0%> (ø) :arrow_down:
...ger/codecs/oer/ilp/InterledgerPaymentOerCodec.java 100% <0%> (ø) 3% <0%> (ø) :arrow_down:
...s/oer/ilqp/QuoteBySourceAmountRequestOerCodec.java 100% <0%> (ø) 3% <0%> (ø) :arrow_down:
.../oer/ilqp/QuoteBySourceAmountResponseOerCodec.java 100% <0%> (ø) 3% <0%> (ø) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89797c6...f46e601. Read the comment docs.

sappenin commented 7 years ago

This fixes #75 and #76.

adrianhopebailie commented 7 years ago

@sappenin You happy for me to merge or want me to revert the module rename?

sappenin commented 7 years ago

@adrianhopebailie The other PRs are merged, so you should be good to pull-in the latest master changes and push this PR.