search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

Merge development into master #85

Closed adrianhopebailie closed 6 years ago

adrianhopebailie commented 6 years ago

Seems like a good time to do this

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@37cb1cb). Click here to learn what that means. The diff coverage is 76.17%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage          ?   76.17%           
  Complexity        ?      216           
=========================================
  Files             ?       68           
  Lines             ?     1784           
  Branches          ?      193           
=========================================
  Hits              ?     1359           
  Misses            ?      327           
  Partials          ?       98
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/interledger/codecs/AbstractCodec.java 0% <0%> (ø) 0 <0> (?)
.../interledger/ilqp/InterledgerQuotingException.java 0% <0%> (ø) 0 <0> (?)
.../org/interledger/InterledgerProtocolException.java 0% <0%> (ø) 0 <0> (?)
...in/java/org/interledger/codecs/CodecException.java 0% <0%> (ø) 0 <0> (?)
src/main/java/org/interledger/codecs/Codec.java 100% <100%> (ø) 1 <1> (?)
...s/oer/ilqp/QuoteBySourceAmountRequestOerCodec.java 100% <100%> (ø) 3 <3> (?)
.../oer/ilqp/QuoteBySourceAmountResponseOerCodec.java 100% <100%> (ø) 3 <3> (?)
...erledger/codecs/InterledgerProtocolErrorCodec.java 100% <100%> (ø) 2 <2> (?)
.../packettypes/QuoteLiquidityResponsePacketType.java 100% <100%> (ø) 1 <1> (?)
.../interledger/codecs/oer/ilp/ConditionOerCodec.java 100% <100%> (ø) 3 <3> (?)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 37cb1cb...782a9c5. Read the comment docs.

adrianhopebailie commented 6 years ago

@sappenin bump...

sappenin commented 6 years ago

I think we should wait until #87 is merged, no?

adrianhopebailie commented 6 years ago

I think we should wait until #87 is merged, no?

Actually I think we should merge and tag this, then we can start implementing the Immutables across all the objects