search

interledger-deprecated / tutorials

Interledger tutorials
17 stars 9 forks source link

fix: hyperlinks between tutorials #28

Closed michielbdejong closed 6 years ago

adrianhopebailie commented 6 years ago

Have you tested these in the rendered website? That's where they need to work the most.

i.e. If these pages are hosted at https://interledger.org/tutorials with a base of https://interledger.org I think they will break

michielbdejong commented 6 years ago

I didn't test them on a rendered site but I did notice that if you click the link in the first paragraph of https://interledger.org/tutorials/http-ilp/ it is now broken, and so this will at least not make it worse.

michielbdejong commented 6 years ago

Pushed it to https://michielbdejong.github.io/tutorials/hosted-ledgers/ - works there.

michielbdejong commented 6 years ago

@adrianhopebailie Can this be merged now?

michielbdejong commented 6 years ago

Just confirmed that on the live site, the issue identified in https://github.com/interledger/tutorials/pull/28#issuecomment-343604975 is now fixed. Thanks!