search

interledger-deprecated / tutorials

Interledger tutorials
17 stars 9 forks source link

Updated letter-shop tutorial #8

Closed adrianhopebailie closed 7 years ago

adrianhopebailie commented 7 years ago

This is a pretty big re-write of @michielbdejong 's awesome tutorial

It teaches the same things and uses the same code. It changes the approach to be more hands on (user completes the code piece by piece) and adds a lot more commentary and logging.

From here users will be ready to move onto tutorials that teach multi-hop (and peer communication using sendRequest) or derived protocols like HTTP-ILP.

michielbdejong commented 7 years ago

When you cd into this repo on this branch and run npm install; npm test you see a lot of lint errors, mostly about spacing and indentation. Would be good to fix those, if possible.

adrianhopebailie commented 7 years ago

How about if we just remove it, and leave it for the streaming-payments tutorial, where it can be made correct from the start?

I think it's useful to have it there to demonstrate the direction we are going. If anything we should explain in the next tutorial why we don't use the condition.

adrianhopebailie commented 7 years ago

When you cd into this repo on this branch and run npm install; npm test you see a lot of lint errors, mostly about spacing and indentation. Would be good to fix those, if possible.

Hmmm. Fixing will be a bit of a pain as I have to copy all the snippets again after they are fixed. Will log an issue to resolve later.