search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

Fix clippy and audit warnings #667

Closed pradovic closed 3 years ago

pradovic commented 3 years ago

cargo clippy and cargo audit have some new warnings since the new version. This is an attempt to simply fix those.

pradovic commented 3 years ago

@koivunej Thanks for checking! I checked cargo audit and cargo clippy ones as well, and they appear to be correct.

koivunej commented 3 years ago

Oki, I am thinking we should just merge this ahead, or have the 24h grace period as usual starting from now. I am for waiting, as there seems to be no rush.

koivunej commented 3 years ago

@emschwartz could you relax the merging requirements as the circleci is now defunct? Please see #669 for the next steps.

koivunej commented 3 years ago

An alternative to getting this in would be to make disable other than the clippy for example in circleci for now and go with a lighter, fix the build by migrating to github actions in the next PR.

pradovic commented 3 years ago

I have included a working circleCI changes, and re-enabled the clippy and audit checks. Can I merge this one without 24h warning, so we can unblock other PRs?

koivunej commented 3 years ago

Yeah lets go ahead and merge, the 24h grace period already passed!