search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

Tracking breaking changes #668

Open koivunej opened 3 years ago

koivunej commented 3 years ago

While handling the latest 1.49 clippy lints in #667, there are at least two public instances of Result<_, ()> which are now nagged by clippy changing of which require a minor version bump:

Given commit 3f1a8de2a359c02c8d8edda88eacdd652d3992bd I had thought that 1.0.0 versions had already been pushed, but in light of us needing to make breaking changes to keep up with clippy, I'd recommend reverting the 1.0.0 bump and going ahead with the next released versions being 0.x series. crates.io doesn't have any 1.0 crates nor does dockerhub, at least as far as I can search it.

koivunej commented 3 years ago

As I already commented on the 667, we need a way to start marking the commits with breaking changes. I suggest conventional commits with ! in the scope and BREAKING CHANGE in the "footer". Also, we need to go back in time to find other breaking changes.

kincaidoneil commented 3 years ago

I'd recommend reverting the 1.0.0 bump and going ahead with the next released versions being 0.x series. crates.io doesn't have any 1.0 crates nor does dockerhub, at least as far as I can search it.

Sounds good to me 👍 (personally... wasn't a big fan of that "1.0" release)