search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

Refactor build and test-md workflows into single file #674

Closed pradovic closed 3 years ago

pradovic commented 3 years ago

Refactor build and test-md to be in a same workflow but a different jobs. No need for separate files.

pradovic commented 3 years ago

For posterity, I initially suggested this to avoid the re-building in the test-md phase. It was attempted but since the --all-features is not used in examples there is still some recompilation. Given my past experiences with github actions I'd prefer to have a single efficient job than multiple as each of the jobs can always get spurious platform issues, but with luck this is faster as is.

I don't think this ci+refactoring needs a 24h grace period, merging this right away.

Thanks. Ok, I will think about the best way to re-use the build step and if I find a solution I like, I will open the PR