search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

Docker releases on gh actions #675

Closed pradovic closed 3 years ago

pradovic commented 3 years ago

Docker releases that mimic the same behavior as before. Docker releases are triggered on:

Tag is derived same as before, using the same scripts. This is only the dry-run and will not push images to dockerhub.

Cc: #678 Cc: #669

koivunej commented 3 years ago

Test failure at https://github.com/interledger-rs/interledger-rs/pull/675/checks?check_run_id=1810927961#step:5:1107

pradovic commented 3 years ago

Test failure at https://github.com/interledger-rs/interledger-rs/pull/675/checks?check_run_id=1810927961#step:5:1107

I noticed as well, which was weird as I did not change any code in the repo. Also, some of other tests failed on a fork, so it might be that gh was slow last night. I will re-run to test what happens

pradovic commented 3 years ago

Test failure at https://github.com/interledger-rs/interledger-rs/pull/675/checks?check_run_id=1810927961#step:5:1107

Yup, now all failed tests passed here, and also on my private repos/forks. It seems to be that there were some connection errors on gh instrances last night.

koivunej commented 3 years ago

As this PR cannot really be tested as a PR (see https://github.com/interledger-rs/interledger-rs/pull/675#discussion_r568640204), so only following the merge we can see if these work or not. I am thinking this doesn't really require a 24h period since either the docker push will work or it'll fail, but it doesn't really concern the code quality as there are no software changes. The previous latest image is already quite old, so in the best case this will refresh it.

pradovic commented 3 years ago

As this PR cannot really be tested as a PR (see #675 (comment)), so only following the merge we can see if these work or not. I am thinking this doesn't really require a 24h period since either the docker push will work or it'll fail, but it doesn't really concern the code quality as there are no software changes. The previous latest image is already quite old, so in the best case this will refresh it.

Just to add a bit more clarification. This is going to be a dry-run and merging this will test the credentials and building process. If everything goes well, another PR with just changing push=true would make it push to a dockerhub.