search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

ilp-node --version contains the same string twice #680

Closed koivunej closed 3 years ago

koivunej commented 3 years ago

Steps to reproduce:

  1. cargo run -p ilp-node -- --version outputs ilp-node 1.0.0ilp-node 1.0.0\n on 243c9797d

I think the string should appear only once there: ilp-node 1.0.0.

For debugging any issues from binary releases it would also be good if this included the commit it was built from: ilp-node 1.0.0 (243c9797d).

I wonder if this could had been broken in some clap update? Couldn't see it after a brief skimming over. There is also a pending TODO related to clap bug which seemed to be fixed already.

koivunej commented 3 years ago

Looked into this a bit, not really a good first issue because this touches the config handling in crates/ilp-node/src/main.rs which might not have any tests even. The double printing happens because clap is basically called twice.