search

interledger / interledger-rs

An easy-to-use, high-performance Interledger implementation written in Rust
http://interledger.rs
Other
201 stars 70 forks source link

fix(docker): make .git available for the build image #699

Closed koivunej closed 3 years ago

koivunej commented 3 years ago

When doing #680 I didn't notice the docker build failure and have been figuring out how to fix it since. Looking more closely to the dockerfile it already uses a two container construction so I was able to identify the issue being "only parts of the working copy are copied into the build container". The fix is obvious in hindsight.

Fixes #694 but we will not know until I merge this into master, we should have a third workflow which depends on both build and test-md and attempts to build the docker images.

koivunej commented 3 years ago

Restarting workflow, not that it tests the changes.

koivunej commented 3 years ago

This is now tested, and should be good to go.

koivunej commented 3 years ago

Should also note that the build process is currently very inefficient taking a long time and is quite difficult to test.