Closed JoblersTune closed 1 day ago
Latest commit: 223d37e1b5f338047ca5aaed186bcca71ea12c3e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | 223d37e1b5f338047ca5aaed186bcca71ea12c3e |
Latest deploy log | https://app.netlify.com/sites/openpayments-preview/deploys/67349d103877830008b32dd8 |
Deploy Preview | https://deploy-preview-517--openpayments-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Does the astro config file also need the following?
plugins: [
starlightLinksValidator({
errorOnLocalLinks: false,
}),
],
This was in the Rafiki update, which is why I ask.
Does the astro config file also need the following?
plugins: [ starlightLinksValidator({ errorOnLocalLinks: false, }), ],
This was in the Rafiki update, which is why I ask.
@melissahenderson this is only needed in docs that contain localhost addresses. So for Rafiki because we have the local playground docs we have links that are localhost links which causes the links validator to fail. I think that's the only docs project that uses localhost links. So no, the links validator is passing here.
The introduction of this feature was because usually localhost links are for dev purposes so including them in a production setup is usually an accident.
Changes proposed in this pull request
Updating dependencies for the docs.
Context