interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.
https://rafiki.dev/
Apache License 2.0
233 stars 83 forks source link

Release Docker Images #233

Closed matdehaast closed 2 years ago

matdehaast commented 2 years ago

Rafiki needs a mechanism to used tagged release that build docker images that are hosted on a container registery. All packages should be able to become a docker image as required. Ideally this should work through github actions

matdehaast commented 2 years ago

@omertoast is going to handle this issue

wilsonianb commented 2 years ago

If we're good with ghcr (vs docker hub), here's how Tigerbeetle images are being published for reference: https://github.com/coilhq/tigerbeetle/pull/38 https://github.com/coilhq/tigerbeetle/pull/40

omertoast commented 2 years ago

Thanks for the recommendation, going with ghcr.

omertoast commented 2 years ago

So, I tried to use Docker Build & Push Action to publish Docker images. But because the current Dockerfile is designed to only work with the yarn docker build plugin, the action fails when it's trying to build it using only the Dockerfile. There are two ways I can get the workflow done:

I think it's more reasonable to go with the first option, so I will be going with that one if no one is against it. I'm also open to any recommendations and comments.