feat(backend): make quote step optional

BlairCurrey commented 2 months ago

Changes proposed in this pull request

handle creating outgoing payment with a an incoming payment and debit amount as alternative to creating only from quoteId
added integration test and bruno example for this flow

Context

fixes #2409 fixes #2573

Checklist

[ ] Related issues linked using fixes #number
[ ] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass
[ ] Bruno collection updated

netlify[bot] commented 2 months ago

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name	Link
Latest commit	9900f933f46997b2693cddd681634bdef9f6fcc2
Latest deploy log	https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/662fbbdcd537260008bf20be

BlairCurrey commented 2 months ago

Do we want to add this functionality in the Admin API as well?

Also, this looks good, I think only the test integration README needs updating IMO

@mkurapov

added support for creating from incoming payment here: https://github.com/interledger/rafiki/pull/2654/commits/a7e59c2eac837a1d8928d1dda2ed3986aa44a702

I opted for a new createOutgoingPaymentFromIncomingPayment resolver. I did this for the more explicit interface that can be enforced at compile. We could instead make all of quoteId, incomingPayment, and debitAmount optional but then bad inputs would have to be caught at runtime. So I think it's a trade between a little duplication in the resolver definition for a much clearer interface. There is no way to just make the input a union of inputs (like it is for the open payments route).

interledger / rafiki