search

interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.
https://rafiki.dev/
Apache License 2.0
233 stars 83 forks source link

[BUG] Webhook check for max retries causes processing of the same event #2664

Closed dragosp1011 closed 5 months ago

dragosp1011 commented 5 months ago

Thanks for taking the time to file a bug report! Please fill out this form as completely as possible.

Bug Report

In recent release a new check for webhooks attempts was introduced that checks for max retries attempts (PR). As the check is happening in the code that is causing the processing of the same events that reached the max attempts and does not go further to newly created webhooks. That is causing the system to be stuck and not processing new payments as the webhooks are not sent. The events that reached max attempts should be ignored and not processed anymore.

tadejgolobic commented 5 months ago

GateHub had this problem today when we went into production. @mkurapov pointed out this issue, I bumped rafiki version to alpha.9 and everything started working. Thank you @dragosp1011 !