feat(2662)!: 2phase incoming and outgoing payments

interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.

https://rafiki.dev/

Apache License 2.0

233 stars 83 forks source link

feat(2662)!: 2phase incoming and outgoing payments #2671

Closed koekiebox closed 4 months ago

koekiebox commented 5 months ago

Changes proposed in this pull request

Address issue: https://github.com/interledger/rafiki/issues/2662

Context

Fixes #2662

Checklist

[x] Related issues linked using fixes #number
[x] Tests added/updated
[x] Documentation added
[x] Make sure that all checks pass
[x] Bruno collection updated

netlify[bot] commented 5 months ago

Deploy Preview for brilliant-pasca-3e80ec ready!

Name	Link
Latest commit	0173ad6a8114c782655f017852a2dc73aeceb97b
Latest deploy log	https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6644c80ebaf89a00080637ce
Deploy Preview	https://deploy-preview-2671--brilliant-pasca-3e80ec.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sabineschaller commented 5 months ago

@koekiebox we discussed this last week and we were wondering if we could make the 2-phase transfer optional on all withdrawals. What do you think?

koekiebox commented 5 months ago

@koekiebox we discussed this last week and we were wondering if we could make the 2-phase transfer optional on all withdrawals. What do you think?

@sabineschaller this should not be a challenge. The accountingService.createWithdrawal will create a 1 or 2 Phase transfer depending on the timeout parameter being > 0. So we can update each of the withdrawal mutations to also have a timeout field as part of the input? Which will also mean the caller would be able to control the timeout for a 2-phase transfer. What do you think?