interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.
https://rafiki.dev/
Apache License 2.0
226 stars 77 forks source link

feat(auth): add logs to routes #2697

Closed njlie closed 1 month ago

njlie commented 1 month ago

Changes proposed in this pull request

Context

Closes #2577.

Checklist

netlify[bot] commented 1 month ago

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
Latest commit b7d26631c2242565fe0c0d13e1f77eeceeeee849
Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/664caf937930dc00089deddf
mkurapov commented 1 month ago

What do you think about original PR review comment?

Should we create an openPaymentsServerErrorMiddleware like we do in backend to catch all of the GNAPErrors to have a single place for a standardized log for each error? (Since most of the logs are added right before the throw).

Might be nice to match the behaviour in backend

njlie commented 1 month ago

What do you think about original PR review comment?

Should we create an openPaymentsServerErrorMiddleware like we do in backend to catch all of the GNAPErrors to have a single place for a standardized log for each error? (Since most of the logs are added right before the throw).

Might be nice to match the behaviour in backend

I think it's possible to have this PR also match that pattern. It'll be slightly different since it's supposed to also return GNAP error codes, but will be mostly similar.