chore(bruno): fix Peer to Peer example requests

interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.

https://rafiki.dev/

Apache License 2.0

233 stars 83 forks source link

chore(bruno): fix Peer to Peer example requests #2701

Closed mkurapov closed 4 months ago

mkurapov commented 4 months ago

Changes proposed in this pull request

Fix createQuote requests in Peer to Peer bruno examples by adding signature header
Tidy up bruno scripts
Fix broken link in doc

Context

Fixes #2700

Checklist

[x] Related issues linked using fixes #number
[ ] Tests added/updated
[x] Documentation added
[ ] Make sure that all checks pass
[x] Bruno collection updated

netlify[bot] commented 4 months ago

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name	Link
Latest commit	706fe82bd763b5745f17ada8fddc4122eb8aa168
Latest deploy log	https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66350f287beb820008384d99

BlairCurrey commented 4 months ago

Just a related observation: Integration tests could have caught this if they signed the requests. Maybe they should (out of scope here though of course). At that point they are looking more and more like E2E tests I guess (I have went back and forth on that so many times 🤪).

EDIT: Nevermind, it was just the bruno requests, not the actual code. Still something we can consider but not really related here.