interledger / rafiki

An open-source, comprehensive Interledger service for wallet providers, enabling them to provide Interledger functionality to their users.
https://rafiki.dev/
Apache License 2.0
226 stars 77 forks source link

feat(2739)!: additional properties for createwalletaddress #2752

Closed koekiebox closed 2 weeks ago

koekiebox commented 4 weeks ago

Story

https://github.com/interledger/rafiki/issues/2739

Changes proposed in this pull request

Context

Checklist

netlify[bot] commented 4 weeks ago

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
Latest commit 8ce14744f48aea202a754cdd2b606f6cec5baabf
Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6661d3201de9db0008316a7c
BlairCurrey commented 3 weeks ago

I think I may have a different interpretation of the "optional" aspect described in the task. It looks like these changes include 2 layers of options:

Maybe @mkurapov can chime in on his original intentions but my interpretation was that we just always fetch the additional properties where visibleInOpenPayments was set to true. So removing the includeAdditionalProperties controlling if we fetch them. In any case, I think this would be simpler without any downside.

I wonder if we should also always return ALL additional properties in the gql api? regardless of visibleInOpenPayments. Or rename visibleInOpenPayments to isPublic/public or something like that which is more generic?