Closed koekiebox closed 2 weeks ago
Name | Link |
---|---|
Latest commit | 8ce14744f48aea202a754cdd2b606f6cec5baabf |
Latest deploy log | https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6661d3201de9db0008316a7c |
I think I may have a different interpretation of the "optional" aspect described in the task. It looks like these changes include 2 layers of options:
includeAdditionalProperties
/fetchAdditionalProperties
controls if additional properties are fetchedvisibleInOpenPayments
controls if properties to be fetched should include visible/non-visibleMaybe @mkurapov can chime in on his original intentions but my interpretation was that we just always fetch the additional properties where visibleInOpenPayments
was set to true
. So removing the includeAdditionalProperties
controlling if we fetch them. In any case, I think this would be simpler without any downside.
I wonder if we should also always return ALL additional properties in the gql api? regardless of visibleInOpenPayments
. Or rename visibleInOpenPayments
to isPublic
/public
or something like that which is more generic?
Story
https://github.com/interledger/rafiki/issues/2739
Changes proposed in this pull request
createWalletAddress
.Context
Checklist
fixes #number