search

interledger / rfcs

Specifications for Interledger and related protocols
https://interledger.org
Other
455 stars 111 forks source link

Fixes #546 #551

Closed sappenin closed 5 years ago

sappenin commented 5 years ago

Fixes #546 by clarifying the STREAM RFC.

Signed-off-by: sappenin sappenin@gmail.com

sappenin commented 5 years ago

I don't think we should make any changes to the spec until we've implemented said changes and have some use case that requires this to be done the same way in all implementations.

Sounds fine to me. I have removed any breaking changes from this PR - the only thing left is non-breaking clarifications to the spec.

In the Java STREAM implementation, we're going to support what JS is doing (and apparently what Rust is going to do). We might experiment with what was proposed earlier in this PR (i.e., respond to a ConnectionAssetDetails frame with a corresponding ConnectionNewAddress frame) and see if it adds any value.

As a community, we can revisit the desired behavior here sometime in the future if we ever decide this is worth changing (see https://github.com/interledger/rfcs/issues/554, which is just a tracking issue, if you're interested).

sappenin commented 5 years ago

@adrianhopebailie The build doesn't seem to be working for whatever reason. Once you determine what the problem is, let me know and I can push another change.

adrianhopebailie commented 5 years ago

@mDuo13 @ryangyoung any idea what could be happening here. Could this be related to the change of template?