search

interledger / rfcs

Specifications for Interledger and related protocols
https://interledger.org
Other
455 stars 111 forks source link

Remove legacy ASN.1 definitions #569

Closed kincaidoneil closed 4 years ago

kincaidoneil commented 4 years ago

I noticed the link in the Interledger v4 RFC links to an "InterledgerPacket" ASN.1 file, which defines older types of packets. I think these files should be removed for clarity:

Can these be safely deleted (and there'll still be in the commit history for future reference)?

sappenin commented 4 years ago

I think everything in that list can be deleted except InterledgerPacket.asn. That still defines the Packet, PacketSet and InterledgerPacket for the current ILPv4 packet types (12, 13, and 14).

I think we could probably get rid of this Liquidity Curve section, though.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

sappenin commented 4 years ago

@kincaidoneil are you going to make the changes suggested above, or should we close this one?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is important, please feel free to bring it up on the next Interledger Community Group Call or in the Gitter chat.

sappenin commented 4 years ago

@kincaidoneil are you going to make the changes suggested above, or should we close this one?

kincaidoneil commented 4 years ago

@sappenin At last... here's that PR!