search

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.
Apache License 2.0
46 stars 2 forks source link

[ENHANCEMENT] update tooltip text #354

Closed tselit closed 1 week ago

tselit commented 1 week ago

Steps to reproduce

  1. Install the extension & pin the extension to the browser window.
  2. Connect the extension to a wallet.
  3. Visit a non-monetized website
  4. Hover over the WM extension's icon

Expected result

When hovering over the WM extension icon, the tooltip displayed should have the following text: "Web Monetization This site is not monetized"

Actual result

When hovering over the WM extension icon, the tooltip displayed should have the following text: "Web Monetization Has access to this site"

Screenshots or videos

image

Additional context

On 22 June, we discussed and agreed on the following solution:

So, the extension's tooltip in Chrome will have the following text:

For all other browser's, the ext tooltip has the following text:

Operating system

Windows

Operating system version

10

Browsers

Chrome

Browser version

Version 126.0.6478.114 (Official Build) (64-bit)

Extension version

alpha build (says v1.0.1)

sidvishnoi commented 1 week ago

The "Has access to this site" part is coming from browser. We can perhaps add more details to the title though. Will investigate.

tselit commented 1 week ago

The "Has access to this site" part is coming from browser. We can perhaps add more details to the title though. Will investigate.

Noted, thanks @sidvishnoi . In that case, as discussed, let us proceed with the following tooltip text: If a site monetized: Web Monetization - Active If a site isn't monetized: Web Monetization - Inactive

Also just acknowledging your feedback that the for the Chrome browser only, the extension cannot suppress text from the browser, such that the following additional text will be part of the tooltip: "Has access to this site"