fix: ensure correct icon is reflected for monetization state - Githubissues

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.

Apache License 2.0

46 stars 2 forks source link

fix: ensure correct icon is reflected for monetization state #355

Closed sidvishnoi closed 1 week ago

sidvishnoi commented 1 week ago

Context

Closes https://github.com/interledger/web-monetization-extension/issues/329.

Changes proposed in this pull request

We were not sending IS_FRAME_MONETIZED due to a premature optimization (not sending it when no tags), so we weren't updating the state when required.
Also had some timing issues with not await-ing.
We now use sender.tab.id to ensure we set the icon for the right tab, and not override it from a stale message from a different tab (race condition).

As discussed in call today, in future we'll try to make use of a TabStateService and use that as source of truth, and reduce reliance on message passing.

raducristianpopa commented 1 week ago

Extension builds preview

Name	Link
Latest commit	bd03b62d9b4704dfa8613ccc2ce082b9fb3b4833
Latest job logs	Run #9611649505
	Download
	Download