fix: show "warning" icon when disconnected

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.

Apache License 2.0

46 stars 2 forks source link

fix: show "warning" icon when disconnected #368

Open sidvishnoi opened 4 days ago

sidvishnoi commented 4 days ago

Context

We were showing the default icon on "enabled" - which is "continuous payments enabled" earlier. I think makes more sense depending on connected state.

Changes proposed in this pull request

Show the "warning" icon if not connected. So finally:

default: if connected warning: if not connected green dot: continuous payment enabled, connected, and has valid link tags red dot: continuous payment enabled, connected, but not has valid link tags

raducristianpopa commented 4 days ago

Extension builds preview

Name	Link
Latest commit	48e4c09433f773144044039718f6c54c8f761ef0
Latest job logs	Run #9678491613
	Download
	Download

sidvishnoi commented 3 days ago

Will use new icons and update logic when to show each icon (similar to one in this PR, but more icons). See https://github.com/interledger/web-monetization-extension/issues/373