interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.
Apache License 2.0
49 stars 3 forks source link

[BUG] Fynbos wallet invalid client error #489

Closed tselit closed 1 month ago

tselit commented 1 month ago

Steps to reproduce

  1. Testing with a ZAR Fynbos wallet
  2. Removed all WM extension keys from the Fynbos wallet
  3. Open the WM extension
  4. Enter the fynbos wallet address and an amount greater than zero
  5. Leave "renew amount monthly" disabled
  6. Click Connect

Expected result

Display error message: Failed to connect. Please make sure you have added the public key to the correct wallet address.

Actual result

Displays error message: invalid client image

Screenshots or videos

From the build shared on the channel 6 Aug: https://www.loom.com/share/0b5b34fdf5104a79a1d4ded00eafe152?sid=de33a394-8138-4e0e-a05a-b00e3f960b1f

Additional context

The same scenario using a USD rafiki.money test payment pointer worked as expected, and the correct error message was displayed: Failed to connect. Please make sure you have added the public key to the correct wallet address.

image

Operating system

Windows

Operating system version

10

Browsers

Chrome

Browser version

Version 127.0.6533.89 (Official Build) (64-bit)

Extension version

the build shared on 6 August on Slack https://interledgerfoundation.slack.com/archives/C06CVJRT5N3/p1722933667156999?thread_ts=1722853980.760009&channel=C06CVJRT5N3&message_ts=1722933667.156999

sidvishnoi commented 1 month ago

Looks like Fynbos hasn't updated to Rafiki v1.0.0-alpha.14 yet, which includes that error handling. Will check with them. If no soon-ish plans, we will have to match both error code and description in extension.

sidvishnoi commented 1 month ago

Fynbos is looking into updating Rafiki tomorrow, so might not need to do this on our end.

sidvishnoi commented 1 month ago

@tselit Fynbos updated today and this issue is now resolved. Please test the extension more with Fynbos wallet to check if there are any other issues.