search

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.
Apache License 2.0
49 stars 3 forks source link

[BUG] Extension does not work in Chrome (ver 128, 64-bit,Ubuntu) #572

Closed lengyel-arpad85 closed 2 weeks ago

lengyel-arpad85 commented 3 weeks ago

Steps to reproduce

  1. add a monetization link to a website
  2. open website in Chrome (ver 128, 64bit, Ubuntu)
  3. have WM extesnion installed (either from store or manually)
  4. open WM extension, observe extension displaying "Website is not monetized"

Expected result

Extension should display normal controls and info, since website has a valid monetization link. All this works on Mac, Chrome, but not on Ubuntu, Chrome

Actual result

Screenshot from 2024-09-05 16-16-24

displayed error persists even after refreshing the page.

as a sanity check I tried relList.supports monetization and even that is giving a false value

Screenshot from 2024-09-05 16-18-51

Screenshots or videos

No response

Additional context

No response

Operating system

Linux

Operating system version

Ubuntu 23.04

Browsers

Chrome

Browser version

Version 128.0.6613.119 (Official Build) (64-bit)

Extension version

0.1.1

sidvishnoi commented 3 weeks ago

Web monetization is aimed to work only on secure contexts (https URLs), as per spec.

I think it would be better to disable the popup/extension (IIRC, browser would show default "cannot access this site" message) or show a different custom message (but might cause additional confusion?) on non-https pages. cc @RabebOthmani

RabebOthmani commented 2 weeks ago

If a website is monetized, we should never show the 'website not monetized' message as it's fundamentally wrong. We can and should a more explicit clear message on why it's not possible to use the WM extension in this instance.

tselit commented 2 weeks ago

Hi @lengyel-arpad85 , Thank you for testing the extension and for reporting this behaviour, we appreciate your time!

Feedback: We have confirmed that the reported behaviour was unrelated to using Ubuntu and Chrome for testing. The WM extension is only compatible with HTTPS compliant websites (as per the WM spec). Therefore, the extension cannot pay any non-HTTPS website, even if the website is web monetized.

Next steps: The extension must give the user a better, more informative message when a site/page is monetized but not secure. This will be resolved in ticket #584

We will go ahead and close this ticket. You are always welcome to reach out directly, via Slack or email, so that we can discuss this or other tickets.

Thanks again 😃

tselit commented 2 weeks ago

Will be addressed in #584

lengyel-arpad85 commented 2 weeks ago

@tselit that's ok, thank you for the clarification just have in mind that in my tests it did work on Mac / Chrome on http and other browsers, the only exception was the LInux / Chrome why I reported it for this combo :)

lengyel-arpad85 commented 2 weeks ago

@tselit that's ok, thank you for the clarification just have in mind that in my tests it did work on Mac / Chrome on http and other browsers, the only exception was the LInux / Chrome why I reported it for this combo :)

update: where it worked with http I was using a dev build, so you can ignore my previous concern

tselit commented 2 weeks ago

Cool, and thanks for closing the loop on this @lengyel-arpad85. Closed ✔️