refactor: introduce `ErrorWithKey` (locales keys as error code) - Githubissues

interledger / web-monetization-extension

An open-source browser extension that enables Web Monetization.

Apache License 2.0

73 stars 5 forks source link

refactor: introduce `ErrorWithKey` (locales keys as error code) #621

Closed sidvishnoi closed 2 months ago

sidvishnoi commented 2 months ago

Context

Closes https://github.com/interledger/web-monetization-extension/issues/620 Extracted from https://github.com/interledger/web-monetization-extension/pull/619 (check out usage in addPublicKeyToWallet + its handler; also in ConnectWalletForm validation handler)

Changes proposed in this pull request

Introduces following helpers:
- ErrorWithKey (extends Error; useful for throwing with stack-trace)
- errorWithKey (lighter version of ErrorWithKey; useful when stack-trace not needed)
- isErrorWithKey (checks if an object is ErrorWithKey or response of errorWithKey)
Extends ErrorResponse and failure to have optional {error?: ErrorWithKeyLike}
Extends translation/localization helpers (t, useTranslation) to allow converting ErrorWithKeyLike to string via _locales/[lang]/message.json

github-actions[bot] commented 2 months ago

Extension builds preview

Name	Link
Latest commit	78bb92b96233491ef28677788952a9ee0e6f4afc
Latest job logs	Run #11011307580
	Download
	Download