fix(ConnectWalletForm): preserve errors on popup reopen

sidvishnoi commented 1 month ago

Context

Part of https://github.com/interledger/web-monetization-extension/issues/613

Changes proposed in this pull request

Screencast from 02-10-24 05:45:59 PM IST.webm

github-actions[bot] commented 1 month ago

Extension builds preview

Name	Link
Latest commit	a356a05ca92614178cfcfb239feb87ca128028c2
Latest job logs	Run #11146038174
	Download
	Download

sidvishnoi commented 1 month ago

Yes, so user knows what went wrong. For example, we open new tab, popup closes:

user closes tab, then we can show "you closed tab too soon" error message.
key add fails, user opens popup again, they connect again - we end up trying to add key over and over, as we lost context on popup reload.

We need that context (even if we don't show error message). These will be cleared when user successfully connects (or resets when user tries to connect again, to be replaced with newer error message); or when browser is closed.

Example when we won't show redirect page with error (but popup was closed on tab open):

sidvishnoi commented 1 month ago

TODO: reset all error and state when wallet address is changed (or add a "reset" button somewhere in error message?)

interledger / web-monetization-extension