search

interledger4j / ilpv4-connector

An ILPv4 Connector implemented in Java
https://java-connector.ilpv4.dev
Apache License 2.0
19 stars 10 forks source link

Finish Unit tests for DefaultNextHopPacketMapperTest #139

Closed sappenin closed 4 years ago

priyankalakhe commented 5 years ago

Hi @sappenin - I'd like to take a crack at this.

sappenin commented 5 years ago

Sure thing - feel free to submit a PR.

Three things to note:

  1. Please make sure you use the checkstyle.xml settings in the project
  2. Try to get as close to 100% test coverage as you can.
  3. Use assertj annotations instead of hamcrest (we're moving the project to assertj over time).

Glad to have you helping out!

priyankalakhe commented 5 years ago

Thanks for the tips @sappenin! Will send out a PR soon.

priyankalakhe commented 5 years ago

Quick question @sappenin - in DefaultNextHopPacketMapperTest.java, there is a mention of a FIXME for a test case named public void determineCurrencyUnit(). I don't see a method with this name in DefaultNextHopPacketMapper.java. Was there something specific you wanted tested for this, from one of the other methods ?

sappenin commented 4 years ago

Was there something specific you wanted tested for this, from one of the other methods ?

No, that's just an outdated test method - you can ignore it if it's not actually a method in DefaultNextHopPacketMapper.

priyankalakhe commented 4 years ago

Awesome - i should be able to send this out for review tomorrow. Thanks for the prompt response, @sappenin.

priyankalakhe commented 4 years ago

https://github.com/sappenin/java-ilpv4-connector/pull/363

sappenin commented 4 years ago

@priyankalakhe thank you so much for this contribution - it was nearly all the way there, but it's been sitting too long so I just incorporated it into #418 which officially closes this issue.

Would love to have you get more involved though if you're interested -- feel free to submit more PRs or get in-touch with us on ILP Slack if you want to discuss more of the work we're doing.

Last but not least, if you want to see what we're working on day-to-day, this is a good place to look: https://github.com/sappenin/java-ilpv4-connector/projects/11