interledger4j / ilpv4-connector

An ILPv4 Connector implemented in Java
https://java-connector.ilpv4.dev
Apache License 2.0
19 stars 10 forks source link

Wrong Javadoc in SettlementController #662

Open georgeroman opened 4 years ago

georgeroman commented 4 years ago

The Javadoc for the return value of processOutgoingMessageFromLocalSettlementEngine from SettlementController seems to be wrong:

https://github.com/interledger4j/ilpv4-connector/blob/master/connector-server/src/main/java/org/interledger/connector/server/spring/controllers/settlement/SettlementController.java#L133-L136

That function returns a byte array, not a SettlementQuantity. It was probably copied over from creditIncomingSettlement.