interledgerjs / btp-packet

Packet parser for Bilateral Transfer Protocol
1 stars 3 forks source link

fix: typo in constant name #14

Closed michielbdejong closed 7 years ago

michielbdejong commented 7 years ago

See https://github.com/interledger/rfcs/blob/master/asn1/CommonLedgerProtocol.asn#L39

dappelt commented 7 years ago

Should we get ride of MIME_APPLICATION_OCTET_STREAM altogether? Might be confusing and it is not yet used in many places.

michielbdejong commented 7 years ago

Let's remove it next time we do a major version release, I don't think it's confusing because it clearly has the 'deprecated' code comment