dappelt
commented
7 years ago This PR questions why you would ever want to serialize, or deserialize, only the 'data' part of a clp packet, and simplifies it all by collapsing the many serialize* functions into one serialize function with a switch statement, and the same for deserialize.
serializing and deserializing are different in this aspect. When a peer is sending a packet we typically don't know its type, so a deserialize function that takes any packet and returns the type and packet data is handy. On the other hand, when you serialize a packet you need to know which type of packet you want to create. Therefore, having several serialize
Anyway, if you want to add a serialize function that takes the packet type as an argument, add this function as an alias (i.e. without removing the existing serialize* functions).
michielbdejong
Rebased on #5. This PR questions why you would ever want to serialize, or deserialize, only the 'data' part of a clp packet, and simplifies it all by collapsing the many serialize* functions into one serialize function with a switch statement, and the same for deserialize.
To indicate what type of clp packet you are serializing, just set the .type field to one of the constants exposed by the module. The single argument for serialize is the same object as what deserialize return, and the simplification this offers can be seen nicely in the unit tests.