Better test suite, fix for non-V8 browsers

interledgerjs / five-bells-condition

JavaScript implementation of Crypto Conditions validation and fulfillment

https://github.com/rfcs/crypto-conditions

Other

31 stars 21 forks source link

Better test suite, fix for non-V8 browsers #53

Closed justmoon closed 8 years ago

justmoon commented 8 years ago

This adds a bunch more tests (from 98 to 473) and fixes an issue where errors could not be constructed in browsers that don't use V8.

Depends on interledger/js-oer-utils#1

codecov-io commented 8 years ago

Current coverage is 94.00% (diff: 96.42%)

Merging #53 into master will increase coverage by 17.92%

@@             master        #53   diff @@
==========================================
  Files            22         23     +1   
  Lines           719        734    +15   
  Methods          99         97     -2   
  Messages          0          0          
  Branches        113        120     +7   
==========================================
+ Hits            547        690   +143   
+ Misses          172         44   -128   
  Partials          0          0

Powered by Codecov. Last update 348d2ce...680fa80

emschwartz commented 8 years ago

Overall LGTM but I don't really know enough about it to 👍 commit https://github.com/interledger/five-bells-condition/pull/53/commits/748238a1d69e904bf493454debe2766696ffad50

justmoon commented 8 years ago

Going to merge. Regarding the RSA code, it should be reviewed in general. @msierchio has offered to do it.