search

interledgerjs / ilp-connector

Reference implementation of an Interledger connector.
Other
133 stars 59 forks source link

Rate error when currency scales don't match when using configured routes? #378

Closed michielbdejong closed 7 years ago

michielbdejong commented 7 years ago

When using configured routes, and quoting between two ledgers, one that's nano-USD and one that's centi-USD, the ratio between source and destination amount is off by a factor 10^7. This is probably due to the CONNECTOR_LEDGERS format which still uses the old 'currency' field, from the days when amounts were expressed as floats.

michielbdejong commented 7 years ago

cc @sharafian @sentientwaffle

sentientwaffle commented 7 years ago

What backend is your connector using? And is this post-connector 21.0.7?

michielbdejong commented 7 years ago

I think this is probably latest master, with the fixerio backend (but it was @sharafian who discovered this bug, I only reported it on his behalf)

sentientwaffle commented 7 years ago

Ok, I talked to @sharafian and it sounds like it was ilp-connector@21.0.1. This issue was fixed in ilp-connector@21.0.7.