interledgerjs / ilp-connector

Reference implementation of an Interledger connector.
Other
136 stars 53 forks source link

Removing remote payment channel still break plugins #450

Open kruisdraad opened 6 years ago

kruisdraad commented 6 years ago

Condition: You have a working client/server peering relation with a remote party. The remote party then removes the paymentchannel on their side. Once down the peering goes down, but the moneyd admin port is still available.

When you restart the connector, the routing seems to startup find (except the broken peer obviously) however it seems to be stuck on bring that peer online. It will report an error like:

debug Error processing BTP packet of type 6: Error: paychan initialization has not completed or has failed.

This still is fine, but after the restart you do not have the admin port listening on port 7769 anymore. The admin gui is one of the few tools that makes it easy to actually trouble shoot these kind of issues. It should always be able to start, even is a single peer misbehaves.

Tempting it would be that if a node is very well connected (lets say every node out there) and then wipes all its payment channels ... all the nodes start misbehaving/getting issues creating a cascading event. We have seen this with individual peerings gone wrong, but on a large scale it might interfere with the stability of the network?

adrianhopebailie commented 6 years ago

@kruisdraad I think the issue of admin API not working if there are broken plugins has been resolved. Are you still seeing this occurring?