search

interledgerjs / ilp-packet

Moved to monorepo in interledgerjs/interledgerjs
https://github.com/interledgerjs/interledgerjs
Other
6 stars 7 forks source link

Update BigNumber import declaration #16

Closed KattMingMing closed 7 years ago

KattMingMing commented 7 years ago

@michielbdejong This will fix the issue you're seeing with BigNumber

jsf-clabot commented 7 years ago

CLA assistant check
All committers have signed the CLA.

michielbdejong commented 7 years ago

And master is green again :) https://circleci.com/gh/interledgerjs/ilp-packet/tree/master

KattMingMing commented 7 years ago

@michielbdejong - For context why you just saw this now is because the package.json adds the dependencies / devDependencies as followed:

 "devDependencies": {
    ...,
    `"@types/bignumber.js": "^4.0.2"`,
   ...,
},
"dependencies": {
    ...,
    "bignumber.js": "^4.0.2",
    ...,
},
...

Since bignumber.js pushed a new version last week to 4.1.0 it bumped due to using a caret in front of the version number which will update to the most recent major version. The previous typing only used module.export and the new typings updated the definition to allow for BigNumber as a default export so you could reference it directly.

Hope that helps! Anyways, glad it's passing again!

michielbdejong commented 7 years ago

Ha, interesting!

Thanks.