search

interledgerjs / ilp-packet

Moved to monorepo in interledgerjs/interledgerjs
https://github.com/interledgerjs/interledgerjs
Other
6 stars 5 forks source link

IlpReject incompatible with ASN.1 definition #29

Closed emschwartz closed 6 years ago

emschwartz commented 6 years ago

serializeIlpReject puts triggeredBy before the message, while the ASN.1 definition in interledger/rfcs#361 has the message first. Which one is correct?

Also, it would be useful for IlpPacket to export a separate interface for IlpReject (rather than just using IlpRejection).

justmoon commented 6 years ago

Let's go with the implementation on this one. The order really doesn't matter and the spec is easiest to change.

emschwartz commented 6 years ago

Resolved by https://github.com/interledger/rfcs/pull/361/commits/acec3561fcc9cf2f9fd2002aa7157930cddd474a