search

interledgerjs / ilp-plugin-btp

This has been moved to the monorepo https://github.com/interledgerjs/interledgerjs
8 stars 7 forks source link

Browserify compatibility #11

Closed mikeb1rd closed 6 years ago

mikeb1rd commented 6 years ago

Compatibility for use in the browser using browserify Example can be found here: https://github.com/mikeb1rd/ilp-plugin-btp-browser-client

Switch to using simple-websocket. Use browser's version of URL if possible. Fix issue with nulling username in URL (property account was incorrect)

mikeb1rd commented 6 years ago

Thinking about this again, it might be better off keeping ws and using a shim for the browser, packaging it with webpack (as per ripple-lib). Thoughts? (see discussion here: https://github.com/ripple/ripple-lib/pull/840)

sharafian commented 6 years ago

Yeah, I think the best way to go about this is to use a polyfill for the ws module.

justmoon commented 6 years ago

Closing this PR, feel free to open a new one using an isomorphic ws module.