search

interledgerjs / ilp-plugin-btp

This has been moved to the monorepo https://github.com/interledgerjs/interledgerjs
8 stars 7 forks source link

fix(browser url): #66

Closed matdehaast closed 5 years ago

matdehaast commented 5 years ago

Currently the browser URL library doesn't handle custom protocols correctly. This was discovered whilst @sublimator and I were trying to get this working in the browser

URL("btp+ws://") image

URL("ws://") image (1)

This PR just make sure to use a helper function to convert the URL from this._server to a browserSafe version before using it

sublimator commented 5 years ago

Looks like it should work to me 👍

sublimator commented 5 years ago

@sentientwaffle @matdehaast We need a release eh ?

matdehaast commented 5 years ago

@sublimator Thanks done, should be on npm in a few minutes