search

interledgerjs / ilp-plugin-xrp-asym-client

Client to Asymmetric XRP Paychan
4 stars 3 forks source link

perf: use sodium for signatures and verification #38

Closed karzak closed 5 years ago

karzak commented 5 years ago

Companion to https://github.com/interledgerjs/ilp-plugin-xrp-asym-server/pull/68

sharafian commented 5 years ago

Is it important to run asym-client from a browser? We definitely use BTP from the browser, but the plugins with settlement built-in are pretty much just used in moneyd right now

codecov-io commented 5 years ago

Codecov Report

Merging #38 into master will increase coverage by 0.02%. The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage    48.8%   48.83%   +0.02%     
==========================================
  Files           1        1              
  Lines         252      258       +6     
==========================================
+ Hits          123      126       +3     
- Misses        129      132       +3
Impacted Files Coverage Δ
index.js 48.83% <61.53%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f31684f...1ffdfdf. Read the comment docs.

karzak commented 5 years ago

Updated to use sodium-universal, as it has similar performance improvement and preserves potential browser compatibility.