search

interledgerjs / moneyd

Connect your machine to the Interledger
109 stars 51 forks source link

Feature request for command "moneyd xrp:info" #77

Open jonaagenilsen opened 5 years ago

jonaagenilsen commented 5 years ago

I've chosen custom names for all my hosts when running moneyd xrp:configure --advanced

But where do those appear except in .moneyd.json file? It's very difficult as it is (today) to know which channel belongs to which host..

Could it be possible to add more options to moneyd xrp:info so it's actually possible to see / sort paymentchannels based on this?

.moneyd.json

{
  "version": 1,
  "uplinks": {
    "xrp": {
      "relation": "parent",
      "plugin": "/usr/lib/node_modules/moneyd-uplink-xrp/node_modules/ilp-plugin-xrp-asym-client/index.js",
      "assetCode": "XRP",
      "assetScale": 6,
      "balance": {
        "minimum": "-Infinity",
        "maximum": "20000",
        "settleThreshold": "5000",
        "settleTo": "10000"
      },
      "sendRoutes": false,
      "receiveRoutes": false,
      "options": {
        "server": "btp+wss://hodling-xrp-com:blablablablablablablablablablablablablablabla@btp.strata-ilsp-1.com",
        "secret": "blablablablabla",
        "address": "blablablablabla",
        "xrpServer": "wss://s2.ripple.com"
      }
    }
  }
}

Now, there's NO way I can differentiate hosts and paymentchannels, except from extracting info in .moneyd.json file and butting the puzzle together.

root@hodling-xrp.com ~$ moneyd xrp:info
fetching channels...
connecting to xrp ledger...
account: blablablablabla
balance: 63.408075 XRP
  reserved: 60 XRP
  available: 3.4080749999999966 XRP

index  channel id   destination                         amount (drops)  balance (drops)  expiry
0      069FD861...  rK6g2UYc4GpQH8DYdPG7wywyQbxkJpQTTN  10,000,000      10,000
1      09817D8A...  rGwijy3SbxwDNb2yAhtP9ThonpG9o47ZY6  10,000,000      0
2      2B7A39F0...  raJ79Cjbwfcp41KBDoscFrfpvivNouvCTt  10,000,000      0
3      415BF08D...  rpvJxLEQEbnNrmvcm6BntLBnD338qVoAUR  10,000,000      10,000
4      61A2A671...  rDy4ZNRAokcmHvD7fPazisKQsE7iq3tCQF  10,000,000      10,000
5      E2EC660A...  rnbKqVFYk9Cnzj4q6VmY88hJR4cSmc9xGt  10,000,000      10,000
6      E3255F0B...  rDy4ZNRAokcmHvD7fPazisKQsE7iq3tCQF  10,000,000      10,000
7      F454D4FA...  rhAG7gdd2CKAeaEQCwz5pkN9o1KK6CPNGn  10,000,000      10,000

Please consider the following: 1) Column 'custom name' to be displayed 2) Don't trunc channel id column 3) Make it possible to sort doing moneyd xrp:info -sort=name / -sort=destination or similar

I'm running the latest version of Moneyd: ├── moneyd@4.1.1 ├── moneyd-uplink-xrp@1.2.5

wilsonianb commented 5 years ago

Just to make sure I understand: you are running multiple instances of moneyd on different servers which are all using the same XRP Ledger account but different connectors?

As is, moneyd (with XRP) appears to double as a general payment channels management tool for the configured account. I'm wondering if it should only display and manage channels with the configured connector (or specific to that instance, if there are multiple moneyd with the same account and connector). Would that actually make things less convenient for people running multiple moneyds?

jonaagenilsen commented 5 years ago

I have 8 Codius-hosts: One moneyd running, and one paymentchannel created on (on each)

Common for all hosts: sharing the same XRP wallet. Works like a charm. But hard (as mentioned) to differentiate which paymentchannel belongs to which host.