interledgerjs / settlement-lightning

⚡️ Settle Interledger payments using the Lightning Network
Apache License 2.0
15 stars 4 forks source link

feat: modular lightning service, minor refactoring #23

Closed kincaidoneil closed 5 years ago

kincaidoneil commented 5 years ago

Breaking: balance is represented differently in the store, the plugin configuration has been updated, and this version can't peer with prior versions of the plugin.

There will likely be subsequent minor breaking changes to support the connector refactor, after which we hope to preserve backwards compatibility.

codecov-io commented 5 years ago

Codecov Report

Merging #23 into master will increase coverage by 4.2%. The diff coverage is 83.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #23     +/-   ##
=========================================
+ Coverage   75.38%   79.59%   +4.2%     
=========================================
  Files           6        6             
  Lines         390      392      +2     
  Branches       71       60     -11     
=========================================
+ Hits          294      312     +18     
+ Misses         61       50     -11     
+ Partials       35       30      -5
Impacted Files Coverage Δ
src/utils/store.ts 80% <ø> (+36.41%) :arrow_up:
src/plugins/server.ts 100% <100%> (+4.54%) :arrow_up:
src/index.ts 70.58% <78.33%> (+2.89%) :arrow_up:
src/lightning.ts 81.15% <81.15%> (ø)
src/account.ts 81.5% <85.1%> (+1.27%) :arrow_up:
src/plugins/client.ts 84% <85.71%> (+8%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 601dd29...78ab790. Read the comment docs.