interledgerjs / settlement-lightning

⚡️ Settle Interledger payments using the Lightning Network
Apache License 2.0
15 stars 4 forks source link

feat: switch to grpc-js, cleanup #30

Closed kincaidoneil closed 5 years ago

kincaidoneil commented 5 years ago

Switch to native JS gRPC client instead of C++ bindings

Miscellaneous

codecov-io commented 5 years ago

Codecov Report

Merging #30 into master will decrease coverage by 1.53%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   85.41%   83.88%   -1.54%     
==========================================
  Files           6        6              
  Lines         336      335       -1     
  Branches       17       17              
==========================================
- Hits          287      281       -6     
- Misses         44       50       +6     
+ Partials        5        4       -1
Impacted Files Coverage Δ
src/plugins/client.ts 92.3% <100%> (+0.64%) :arrow_up:
src/plugins/server.ts 90% <75%> (-5%) :arrow_down:
src/types/plugin.ts 80% <80%> (ø)
src/lightning.ts 80.95% <87.5%> (-4.05%) :arrow_down:
src/index.ts 90.1% <93.33%> (+1.09%) :arrow_up:
src/account.ts 78.46% <94.73%> (-2.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 762e651...d1b4a8d. Read the comment docs.