search

interlock-network / threatslayer

A Chrome browser extension that protects you from malicious sites.
GNU General Public License v3.0
12 stars 3 forks source link

Blair/manifest v3 refactor #72

Closed blairmunroakusa closed 1 year ago

blairmunroakusa commented 1 year ago

This needs to be merged. I am happy to field all the questions, but this merge must happen, and the structure and format of the refactor MUST be preserved moving into future versions.

The only exception I can think of is if the Chrome store rejects it. This would be surprising if so, for this refactor is significantly less permissive (it avoids the host permission...thus avoids the scary on-install warning that 'this extension can do everything to you'...though I need to verify this with the Chrome CLI upgrade tool).

Finally, if we are to be integrating TS+ with blockchain and dApps (and any other nontrivial functionalities) this refactor is essential.

And all the other stuff.

jmercouris commented 1 year ago

We are already using manifest v3. This is specifically to remove the access to all URLs though? Shall we merge this against the development branch rather than master to avoid a lot of changes appearing that are not related to this PR?

blairmunroakusa commented 1 year ago

@jmercouris hey John, just saw your comment. This branch is overboard. I am creating a new PR with only the essential changes...that is, the simplified URL scanning, the directory and naming change, and cleaned up miscellaneous icons and whatnot. I will add you a reviewer to that one.

Closing. Irrelevant.