search

interlynk-io / sbomqs

SBOM quality score - Quality metrics for your sboms
Apache License 2.0
158 stars 20 forks source link

add ntia compliance report #286

Open viveksahu26 opened 1 month ago

viveksahu26 commented 1 month ago

closes: https://github.com/interlynk-io/sbomqs/issues/242

This PR will add NTIA minimum element compliance report. For now I have only updated README for NTIA minimum element compliance report.

riteshnoronha commented 1 month ago

@viveksahu26 this does not look accurate to me.

viveksahu26 commented 1 month ago

No, it's not yet completed. It's in process. I have simply added NTIA compliance readme fow now, code part is still left.

viveksahu26 commented 1 month ago

Hey @riteshnoronha , can you go through this NTIA minimum elements compliance report readme and let me know what changes to be made. The recommended data-fields are there in the NTIA minimum elements report - on page 15, so that's why I have added. We can also mark it as optional field.

Apart from that one thing I have noticed that the cra_score.go is 95% same as oct_score.go except some print statement. Similarly for cra_report.go and oct_report.go. And again for NTIA we have to repeat it and that would be ntia_score.go and ntia_report.go. Can we generalized these in a common package, which will contain both score.go and report.go functionality. WDT ??

viveksahu26 commented 1 month ago

@riteshnoronha , any update here ?

viveksahu26 commented 3 weeks ago

Hey @riteshnoronha, somewhat it's ready for review. Checkout this ntia compliance feature. And if changes let me know.