intermezzOS / intermezzOS.github.io

The website for intermezzOS
http://intermezzos.github.io/
14 stars 5 forks source link

fix(a11y): increase contrast on elements #17

Closed varjmes closed 8 years ago

varjmes commented 8 years ago

:wave:

Hey @steveklabnik, thanks for introducing me to intermezzOS, this looks so cool. Also hi, @ashleygwilliams :)

I noticed that there were a few contrasting problems on the website:

intermezzos_before

(Analysed using totally.js)

So I updated some of the colours:

intermezzos_after

I realise you might want to go in a totally different direction, but I thought I'd at least offer up some suggestions in case they you liked them. No hard feelings whatsoever if you don't!

Thanks again, and have a calm and casual New Year.

thumbsup

steveklabnik commented 8 years ago

I do like this! We were actually split between blue and purple. If you had to pick a purple, would that be better or worse, do you think? I don't know much about contrast.

varjmes commented 8 years ago

I actually love purple, so I picked a nice purple:

Let me know what you think and I can change my code :)

intermezzos_after_purple
varjmes commented 8 years ago

Also the colour you decide on isn't the clincher. Contrast is about how readable the text element is against it's background, so we could even do rainbow if worked :)

PS. My vote is for the purple

steveklabnik commented 8 years ago

Blue and purple are just my favorites. :) that color looks great!

On Dec 31, 2015, 12:50 -0500, Charlotte Spencernotifications@github.com, wrote:

Also the colour you decide on isn't the clincher. Contrast is about how readable the text element is against it's background, so we could even do rainbow if worked :)

— Reply to this email directly orview it on GitHub(https://github.com/intermezzOS/intermezzOS.github.io/pull/17#issuecomment-168227559).

varjmes commented 8 years ago

Awesome, let me know which one you decide and I'll squash the commit and you can do with it what you wish :D

steveklabnik commented 8 years ago

I don't mind leaving this un-squashed. Thanks!

varjmes commented 8 years ago

:tada: